[dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine

Jerin Jacob jerin.jacob at caviumnetworks.com
Thu Oct 4 16:16:49 CEST 2018


-----Original Message-----
> Date: Thu, 4 Oct 2018 13:45:42 +0000
> From: "Iremonger, Bernard" <bernard.iremonger at intel.com>
> To: Jerin Jacob <jerin.jacob at caviumnetworks.com>, "Lu, Wenzhuo"
>  <wenzhuo.lu at intel.com>, "Wu, Jingjing" <jingjing.wu at intel.com>
> CC: "dev at dpdk.org" <dev at dpdk.org>, "shahafs at mellanox.com"
>  <shahafs at mellanox.com>
> Subject: RE: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4
>  checksum for csum engine
> 
> Hi Jerin,

Hi Iremonger,

> 
> > -----Original Message-----
> > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> > Sent: Wednesday, October 3, 2018 7:17 PM
> > To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu, Jingjing
> > <jingjing.wu at intel.com>; Iremonger, Bernard
> > <bernard.iremonger at intel.com>
> > Cc: dev at dpdk.org; shahafs at mellanox.com; Jerin Jacob
> > <jerin.jacob at caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4
> > checksum for csum engine
> >
> > Collect and prints the statistics for PKT_RX_EL4_CKSUM_BAD errors.
> >
> > Signed-off-by: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
> > ---
> 
> <snip>
> 
> The following checkpatch warnings should probably be fixed
> 
> WARNING:LONG_LINE: line over 80 characters
> #86: FILE: app/test-pmd/testpmd.c:1043:
> +                       printf("  Bad-ipcsum: %-14"PRIu64" Bad-l4csum: %-14"PRIu64"Bad-outer-l4csum: %-14"PRIu64"\n",
> 
> WARNING:LONG_LINE: line over 80 characters
> #98: FILE: app/test-pmd/testpmd.c:1063:
> +                       printf("  Bad-ipcsum:%14"PRIu64"    Bad-l4csum:%14"PRIu64"    Bad-outer-l4csum: %-14"PRIu64"\n",
>

AFAIK, printf's string can be >80 to allow string strip


 


More information about the dev mailing list