[dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition

[Ananyev, Konstantin]

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com]
> Sent: Saturday, October 6, 2018 9:16 AM
> To: Thomas Monjalon <thomas at monjalon.net>
> Cc: Yigit, Ferruh <ferruh.yigit at intel.com>; Andrew Rybchenko <arybchenko at solarflare.com>; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Wu,
> Jingjing <jingjing.wu at intel.com>; Iremonger, Bernard <bernard.iremonger at intel.com>; Mcnamara, John <john.mcnamara at intel.com>;
> Kovacevic, Marko <marko.kovacevic at intel.com>; Olivier Matz <olivier.matz at 6wind.com>; dev at dpdk.org; shahafs at mellanox.com;
> Ananyev, Konstantin <konstantin.ananyev at intel.com>; didier.pallard at 6wind.com
> Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition
> 
> -----Original Message-----
> > Date: Sat, 06 Oct 2018 00:44:52 +0200
> > From: Thomas Monjalon <thomas at monjalon.net>
> > To: Ferruh Yigit <ferruh.yigit at intel.com>, Jerin Jacob
> >  <jerin.jacob at caviumnetworks.com>, Andrew Rybchenko
> >  <arybchenko at solarflare.com>
> > Cc: Wenzhuo Lu <wenzhuo.lu at intel.com>, Jingjing Wu <jingjing.wu at intel.com>,
> >  Bernard Iremonger <bernard.iremonger at intel.com>, John McNamara
> >  <john.mcnamara at intel.com>, Marko Kovacevic <marko.kovacevic at intel.com>,
> >  Olivier Matz <olivier.matz at 6wind.com>, dev at dpdk.org, shahafs at mellanox.com,
> >  "Ananyev, Konstantin" <konstantin.ananyev at intel.com>,
> >  didier.pallard at 6wind.com
> > Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP
> >  checksum definition
> >
> >
> > 05/10/2018 22:04, Ferruh Yigit:
> > > On 10/4/2018 6:59 AM, Jerin Jacob wrote:
> > > > From: Andrew Rybchenko <arybchenko at solarflare.com>
> > > >> On 03.10.2018 21:14, Jerin Jacob wrote:
> > > >>> From: Andrew Rybchenko <arybchenko at solarflare.com>
> > > >>>> On 03.10.2018 20:12, Jerin Jacob wrote:
> > > >>>>> From: Jerin Jacob <jerin.jacob at caviumnetworks.com>
> > > >>>>>> From: Andrew Rybchenko <arybchenko at solarflare.com>
> > > >>>>>>> 3. PKT_RX_L4_CKSUM_MASK description says nothing if it is inner or outer.
> > > >>>>>>>      May be it is not directly related to changeset, but I think it would be really
> > > >>>>>>>      useful to clarify it.
> > > >>>>>> I will update the comment.
> > > >>>>> Hi Andrew,
> > > >>>>>
> >
> > However, we should re-visit the flag PKT_RX_EIP_CKSUM_BAD.
> 
> Do we need to block this patch due to the exiting PKT_RX_EIP_CKSUM_BAD
> definition?
> 
> I already added the author of the PKT_RX_EIP_CKSUM_BAD flag and ethdev and mbuf
> maintainers in this list. So what else I need make forward progress
> on this patch?
> 
> I think, the definition of PKT_RX_EIP_CKSUM_BAD based on HW capability. It
> is safe to assume that ALL HW can support CKSUM BAD if the feature is
> available and hence it is more portable.

Yes, as I remember PKT_RX_EIP_CKSUM_BAD is based on DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM.
Konstantin

> 
> >
> >