[dpdk-dev] [PATCH 4/5] ethdev: remove deprecated attach/detach functions
Andrew Rybchenko
arybchenko at solarflare.com
Mon Oct 8 09:28:08 CEST 2018
On 10/8/18 1:25 AM, Thomas Monjalon wrote:
> The hotplug attach/detach features are implemented in EAL layer.
> There is a new ethdev iterator to retrieve ports from ethdev layer.
>
> As announced earlier, the (buggy) ethdev functions are now removed.
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
<...>
> diff --git a/doc/guides/contributing/documentation.rst b/doc/guides/contributing/documentation.rst
> index 097575ad7..063c8b6c4 100644
> --- a/doc/guides/contributing/documentation.rst
> +++ b/doc/guides/contributing/documentation.rst
> @@ -615,19 +615,14 @@ The following are some guidelines for use of Doxygen in the DPDK API documentati
> .. code-block:: c
>
> /**
> - * Attach a new Ethernet device specified by arguments.
> - *
> - * @param devargs
> - * A pointer to a strings array describing the new device
> - * to be attached. The strings should be a pci address like
> - * `0000:01:00.0` or **virtual** device name like `net_pcap0`.
> - * @param port_id
> - * A pointer to a port identifier actually attached.
> + * Try to take the lock.
> *
> + * @param sl
> + * A pointer to the spinlock.
> * @return
> - * 0 on success and port_id is filled, negative on error.
> + * 1 if the lock is successfully taken; 0 otherwise.
> */
> - int rte_eth_dev_attach(const char *devargs, uint8_t *port_id);
> + int rte_spinlock_trylock (rte_spinlock_t *sl);
>
> * Doxygen supports Markdown style syntax such as bold, italics, fixed width text and lists.
> For example the second line in the ``devargs`` parameter in the previous example will be rendered as:
I think it would be better if the hunk goes separately.
It is really confusing in the changeset.
More information about the dev
mailing list