[dpdk-dev] [PATCH v2 2/4] drivers: prefix global variables with module name
Shreyansh Jain
shreyansh.jain at nxp.com
Mon Oct 8 14:18:52 CEST 2018
On Friday 05 October 2018 09:56 PM, Ferruh Yigit wrote:
> Some global variables are defined with generic names, add component name
> as prefix to variables to prevent collusion with application variables.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> drivers/bus/dpaa/include/fsl_fman_crc64.h | 8 ++--
[...]
>
> diff --git a/drivers/bus/dpaa/include/fsl_fman_crc64.h b/drivers/bus/dpaa/include/fsl_fman_crc64.h
> index bf162f3ac..08ad63042 100644
> --- a/drivers/bus/dpaa/include/fsl_fman_crc64.h
> +++ b/drivers/bus/dpaa/include/fsl_fman_crc64.h
> @@ -42,9 +42,9 @@ struct fman_crc64_t {
> uint64_t initial;
> uint64_t table[1 << 8];
> };
> -extern struct fman_crc64_t FMAN_CRC64_ECMA_182;
> +extern struct fman_crc64_t fman_crc64_ecma_182;
> #define DECLARE_FMAN_CRC64_TABLE() \
> -struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \
> +struct fman_crc64_t fman_crc64_ecma_182 = { \
> 0xFFFFFFFFFFFFFFFFULL, \
> { \
> 0x0000000000000000ULL, 0xb32e4cbe03a75f6fULL, \
> @@ -183,7 +183,7 @@ struct fman_crc64_t FMAN_CRC64_ECMA_182 = { \
> */
> static inline uint64_t fman_crc64_init(void)
> {
> - return FMAN_CRC64_ECMA_182.initial;
> + return fman_crc64_ecma_182.initial;
> }
>
> /* Updates the CRC with arbitrary data */
> @@ -192,7 +192,7 @@ static inline uint64_t fman_crc64_update(uint64_t crc,
> {
> uint8_t *p = data;
> while (len--)
> - crc = FMAN_CRC64_ECMA_182.table[(crc ^ *(p++)) & 0xff] ^
> + crc = fman_crc64_ecma_182.table[(crc ^ *(p++)) & 0xff] ^
> (crc >> 8);
> return crc;
> }
[...]
For the change above:
Acked-by: Shreyansh Jain <shreyansh.jain at nxp.com>
More information about the dev
mailing list