[dpdk-dev] [PATCH v1] eal: use correct data type for slab operations

Dumitrescu, Cristian cristian.dumitrescu at intel.com
Mon Oct 8 17:57:22 CEST 2018



> -----Original Message-----
> From: Dumitrescu, Cristian
> Sent: Monday, September 24, 2018 6:12 PM
> To: Vivek Sharma <vivek.sharma at caviumnetworks.com>
> Cc: Sharma, Vivek <Vivek.Sharma at cavium.com>; stable at dpdk.org;
> dev at dpdk.org
> Subject: RE: [PATCH v1] eal: use correct data type for slab operations
> 
> 
> 
> > -----Original Message-----
> > From: Vivek Sharma [mailto:vivek.sharma at caviumnetworks.com]
> > Sent: Monday, September 24, 2018 4:50 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu at intel.com>
> > Cc: Sharma, Vivek <Vivek.Sharma at cavium.com>; stable at dpdk.org;
> > dev at dpdk.org
> > Subject: Re: [PATCH v1] eal: use correct data type for slab operations
> >
> > + dev.
> > +cristian(Bitmap maintainer)
> >
> > Please review.
> >
> > Thanks!
> >
> > On Monday 24 September 2018 09:08 PM, Vivek Sharma wrote:
> > > Currently, slab operations use unsigned long data type for 64-bit slab
> > > related operations. On target 'i686-native-linuxapp-gcc', unsigned long
> > > is 32-bit and thus, slab operations breaks on this target. Changing slab
> > > operations to use unsigned long long for correct functioning on all
> targets.
> > >
> > > Fixes: de3cfa2c9823 ("sched: initial import")
> > > Fixes: 693f715da45c ("remove extra parentheses in return statement")
> > > CC: stable at dpdk.org
> > >
> > > Signed-off-by: Vivek Sharma <vivek.sharma at caviumnetworks.com>
> > > ---
> > >  lib/librte_eal/common/include/rte_bitmap.h | 14 +++++++-------
> > >  test/test/test_bitmap.c                    | 18 ++++++++++++++++++
> > >  2 files changed, 25 insertions(+), 7 deletions(-)
> > >
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>

Applied to next-qos tree, thanks!


More information about the dev mailing list