[dpdk-dev] [PATCH v4 06/19] vhost: define postcopy protocol flag

Tiwei Bie tiwei.bie at intel.com
Tue Oct 9 13:41:30 CEST 2018


On Mon, Oct 08, 2018 at 05:25:44PM +0200, Maxime Coquelin wrote:
> Signed-off-by: Dr. David Alan Gilbert <dgilbert at redhat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> Acked-by: Ilya Maximets <i.maximets at samsung.com>
> ---
>  lib/librte_vhost/rte_vhost.h | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Tiwei Bie <tiwei.bie at intel.com>

> 
> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
> index b02673d4a..b3cc6990d 100644
> --- a/lib/librte_vhost/rte_vhost.h
> +++ b/lib/librte_vhost/rte_vhost.h
> @@ -66,6 +66,10 @@ extern "C" {
>  #define VHOST_USER_PROTOCOL_F_HOST_NOTIFIER 11
>  #endif
>  
> +#ifndef VHOST_USER_PROTOCOL_F_PAGEFAULT
> +#define VHOST_USER_PROTOCOL_F_PAGEFAULT 8
> +#endif

Do we want to keep these defines sorted? I.e. define it after
VHOST_USER_PROTOCOL_F_CRYPTO_SESSION (which is defined as 7).

> +
>  /** Indicate whether protocol features negotiation is supported. */
>  #ifndef VHOST_USER_F_PROTOCOL_FEATURES
>  #define VHOST_USER_F_PROTOCOL_FEATURES	30
> -- 
> 2.17.1
> 


More information about the dev mailing list