[dpdk-dev] [PATCH v4 02/22] net/atlantic: logging macroes and some typedefs

Ferruh Yigit ferruh.yigit at intel.com
Wed Oct 10 12:24:57 CEST 2018


On 10/9/2018 10:31 AM, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous at aquantia.com>

<...>

> @@ -168,3 +171,16 @@ atl_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  RTE_PMD_REGISTER_PCI(net_atlantic, rte_atl_pmd);
>  RTE_PMD_REGISTER_PCI_TABLE(net_atlantic, pci_id_atl_map);
>  RTE_PMD_REGISTER_KMOD_DEP(net_atlantic, "* igb_uio | uio_pci_generic");
> +
> +RTE_INIT(atl_init_log);
> +static void
> +atl_init_log(void)

You can merge these two:

RTE_INIT(atl_init_log)
{
....
}

> +{
> +	atl_logtype_init = rte_log_register("pmd.atlantic.init");

Log type string format is "pmd.net.atlantic.init"

> +	if (atl_logtype_init >= 0)
> +		rte_log_set_level(atl_logtype_init, RTE_LOG_DEBUG);
> +	atl_logtype_driver = rte_log_register("pmd.atlantic.driver");

same here related to format.


More information about the dev mailing list