[dpdk-dev] [PATCH v4 09/22] net/atlantic: RX side structures and implementation

Ferruh Yigit ferruh.yigit at intel.com
Wed Oct 10 12:29:12 CEST 2018


On 10/9/2018 10:31 AM, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh at aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous at aquantia.com>

<...>

> +int
> +atl_start_queues(struct rte_eth_dev *dev)
>  {
> +	int i;
> +
> +	PMD_INIT_FUNC_TRACE();
> +
> +	for (i = 0; i < dev->data->nb_rx_queues; i++) {
> +		if (atl_rx_queue_start(dev, i) != 0) {
> +			PMD_DRV_LOG(ERR, "Start Rx queue %d failed", i);

When there are multiple port it can be hard to find out queue of which port, you
may want to add port_id information too in logs.

This comment is valid for multiple places.


More information about the dev mailing list