[dpdk-dev] [PATCH v3 1/3] drivers/bus: move driver assignment to end of probing

Andrew Rybchenko arybchenko at solarflare.com
Thu Oct 11 12:53:06 CEST 2018


On 10/8/18 1:09 AM, Thomas Monjalon wrote:
> The PCI mapping requires to know the PCI driver to use,
> even before the probing is done. That's why the PCI driver is
> referenced early inside the PCI device structure. See
> 1d20a073fa5e ("bus/pci: reference driver structure before mapping")
>
> However the rte_driver does not need to be referenced in rte_device
> before the device probing is done.
> By moving back this assignment at the end of the device probing,
> it becomes possible to make clear the status of a rte_device.
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> ---
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index c7695d108..d63e68045 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -160,14 +160,12 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
>   	 * driver flags for adjusting configuration.
>   	 */
>   	dev->driver = dr;
> -	dev->device.driver = &dr->driver;

It breaks net/sfc and I guess other drivers which use 
rte_eth_dma_zone_reserve()
from probe. The function makes zone name using dev->device->driver->name.

Andrew.


More information about the dev mailing list