[dpdk-dev] [PATCH v4 2/4] drivers/bus: move driver assignment to end of probing

Andrew Rybchenko arybchenko at solarflare.com
Fri Oct 12 09:44:53 CEST 2018


Hi, Thomas,

On 10/12/18 12:02 AM, Thomas Monjalon wrote:
> The PCI mapping requires to know the PCI driver to use,
> even before the probing is done. That's why the PCI driver is
> referenced early inside the PCI device structure. See
> commit 1d20a073fa5e ("bus/pci: reference driver structure before mapping")
>
> However the rte_driver does not need to be referenced in rte_device
> before the device probing is done.
> By moving back this assignment at the end of the device probing,
> it becomes possible to make clear the status of a rte_device.
>
> Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>

Have you seen driver->name usage in drivers/net/szedata2/rte_eth_szedata2.c
rte_szedata2_eth_dev_init() which is used from probe?

It looks like drivers/net/mlx5/mlx5.c
mlx5_pci_probe()->mlx5_dev_spawn()->mlx5_dev_to_port_id() goes
to device->driver. Is the code OK with the move?

I've added above drivers maintainers in CC.


More information about the dev mailing list