[dpdk-dev] [PATCH v3 3/7] hash: correct key store element alignment

Wang, Yipeng1 yipeng1.wang at intel.com
Sat Oct 13 03:20:41 CEST 2018


>-----Original Message-----
>From: Honnappa Nagarahalli [mailto:honnappa.nagarahalli at arm.com]
>Sent: Thursday, October 11, 2018 11:32 PM
>To: Richardson, Bruce <bruce.richardson at intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>
>Cc: dev at dpdk.org; Wang, Yipeng1 <yipeng1.wang at intel.com>; honnappa.nagarahalli at arm.com; dharmik.thakkar at arm.com;
>gavin.hu at arm.com; nd at arm.com
>Subject: [PATCH v3 3/7] hash: correct key store element alignment
[Wang, Yipeng] "correct" -> "improve"?
>
>Correct the key store array element alignment. This is required to
>make 'pdata' in 'struct rte_hash_key' align on the correct boundary.
[Wang, Yipeng] 
More explanation in commit message is appreciated, because people may not understand
what is "correct" boundary.
e.g. Previously pdata could spread across multiple cache lines, which makes the access of pdata
non-atomic which may have performance implications.

Otherwise
Reviewed-by: Yipeng Wang <yipeng1.wang at intel.com>



More information about the dev mailing list