[dpdk-dev] [PATCH v3 0/2] ethdev port freeing

Thomas Monjalon thomas at monjalon.net
Mon Oct 15 01:20:18 CEST 2018


The function rte_eth_dev_detach() is freeing a port and its underlying
rte_device object. The issue is that we may have several ports
associated to the same rte_device.

The right replacement is to free the port, and free the rte_device
if no more ports.
At ethdev level, the public function for port freeing is rte_eth_dev_close().
The only miss is rte_eth_dev_release_port() to free all port resources.


Changes in v3:
  - free queues, MAC addresses and private structure
    in rte_eth_dev_release_port.


Thomas Monjalon (2):
  ethdev: free all common data when releasing port
  ethdev: complete closing of port

 drivers/net/af_packet/rte_eth_af_packet.c |  2 --
 drivers/net/ark/ark_ethdev.c              |  1 -
 drivers/net/avf/avf_ethdev.c              |  3 ---
 drivers/net/avp/avp_ethdev.c              |  5 ----
 drivers/net/axgbe/axgbe_ethdev.c          |  3 ---
 drivers/net/bnxt/bnxt_ethdev.c            |  8 ------
 drivers/net/bonding/rte_eth_bond_pmd.c    |  7 +----
 drivers/net/cxgbe/cxgbe_main.c            | 16 ++----------
 drivers/net/cxgbe/cxgbevf_main.c          |  9 +------
 drivers/net/dpaa/dpaa_ethdev.c            | 10 -------
 drivers/net/dpaa2/dpaa2_ethdev.c          | 10 -------
 drivers/net/e1000/em_ethdev.c             |  3 ---
 drivers/net/e1000/igb_ethdev.c            |  6 -----
 drivers/net/enetc/enetc_ethdev.c          |  4 +--
 drivers/net/failsafe/failsafe.c           |  3 ---
 drivers/net/fm10k/fm10k_ethdev.c          |  8 ------
 drivers/net/i40e/i40e_ethdev.c            |  3 ---
 drivers/net/i40e/i40e_ethdev_vf.c         |  3 ---
 drivers/net/ixgbe/ixgbe_ethdev.c          |  9 -------
 drivers/net/kni/rte_eth_kni.c             |  2 --
 drivers/net/liquidio/lio_ethdev.c         |  3 ---
 drivers/net/mlx4/mlx4.c                   |  3 +--
 drivers/net/mlx5/mlx5.c                   |  5 +---
 drivers/net/mvneta/mvneta_ethdev.c        | 16 ++++--------
 drivers/net/mvpp2/mrvl_ethdev.c           | 16 ++++--------
 drivers/net/netvsc/hn_ethdev.c            | 11 --------
 drivers/net/null/rte_eth_null.c           |  2 --
 drivers/net/octeontx/octeontx_ethdev.c    | 29 ++++++++------------
 drivers/net/pcap/rte_eth_pcap.c           |  7 -----
 drivers/net/qede/qede_ethdev.c            |  5 ----
 drivers/net/ring/rte_eth_ring.c           |  4 ---
 drivers/net/sfc/sfc_ethdev.c              |  3 ---
 drivers/net/softnic/rte_eth_softnic.c     |  6 ++---
 drivers/net/szedata2/rte_eth_szedata2.c   |  1 -
 drivers/net/tap/rte_eth_tap.c             |  1 -
 drivers/net/vhost/rte_eth_vhost.c         | 13 +++------
 drivers/net/virtio/virtio_ethdev.c        |  3 ---
 drivers/net/virtio/virtio_user_ethdev.c   |  3 ---
 drivers/net/vmxnet3/vmxnet3_ethdev.c      |  3 ---
 lib/librte_ethdev/rte_ethdev.c            | 32 +++++++++--------------
 lib/librte_ethdev/rte_ethdev.h            |  3 +--
 lib/librte_ethdev/rte_ethdev_pci.h        | 11 --------
 42 files changed, 47 insertions(+), 248 deletions(-)

-- 
2.19.0



More information about the dev mailing list