[dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM SOC

Shahaf Shuler shahafs at mellanox.com
Tue Oct 16 09:48:40 CEST 2018


Tuesday, October 16, 2018 9:51 AM, Ori Kam:
> Subject: RE: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM
> SOC
> 
> 
> 
> > -----Original Message-----
> > From: dev <dev-bounces at dpdk.org> On Behalf Of Shahaf Shuler
> > Sent: Tuesday, October 16, 2018 9:05 AM
> > To: Yongseok Koh <yskoh at mellanox.com>
> > Cc: dev at dpdk.org; Ori Kam <orika at mellanox.com>; Xueming(Steven) Li
> > <xuemingl at mellanox.com>
> > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix compilation issue on ARM
> > SOC
> >
> > On some ARM environment, the below compilation error will be seen
> >
> > dpdk/drivers/net/mlx5/mlx5_flow_dv.c: In function
> > 'flow_dv_translate_item_nvgre':
> > /tmp/dpdk/drivers/net/mlx5/mlx5_flow_dv.c:785:22: error: pointer
> > targets in initialization differ in signedness [-Werror=pointer-sign]
> >   const char *tni_v = nvgre_v->tni;
> >
> > The reason for this error is that nvgre_v->tni is defined as byte
> > array in size of 3B. However the code in the function iterate till the
> > 4B in order to copy/set also the subsequent field after it (flow_id)
> >
> > Fixing by pointing to this struct from a different pointer.
> >
> > Fixes: fc2c498ccb94 ("net/mlx5: add Direct Verbs translate items")
> > Cc: orika at mellanox.com
> > Cc: xuemingl at mellanox.com
> >
> > Signed-off-by: Shahaf Shuler <shahafs at mellanox.com>
> > ---
> >
> > On v2:
> >  - changed pointer names.
> >  - added pointer for the tni and flow id mask
> >
> > ---

[...]

> > 2.12.0
> 
> 
> Acked-by: Ori Kam <orika at mellanox.com>

Applied to next-net-mlx, thanks. 

> 
> Thanks,
> Ori



More information about the dev mailing list