[dpdk-dev] [PATCH v4 5/6] ethdev: remove deprecated attach/detach functions

Thomas Monjalon thomas at monjalon.net
Tue Oct 16 14:12:37 CEST 2018


16/10/2018 13:03, Ferruh Yigit:
> On 10/9/2018 11:33 PM, Thomas Monjalon wrote:
> > The hotplug attach/detach features are implemented in EAL layer.
> > There is a new ethdev iterator to retrieve ports from ethdev layer.
> > 
> > As announced earlier, the (buggy) ethdev functions are now removed.
> > 
> > Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
> > Reviewed-by: Andrew Rybchenko <arybchenko at solarflare.com>
> 
> <...>
> 
> > @@ -53,7 +53,6 @@ Programmer's Guide
> >      packet_framework
> >      vhost_lib
> >      metrics_lib
> > -    port_hotplug_framework
> 
> Any replacement documentation for hotplug?

No.
We should improve the documentation about device management in general.
I will try to improve it after -rc2.

> > +* ethdev: The deprecated functions attach/detach were removed in 18.11.
> > +  ``rte_eth_dev_attach`` can be replaced by ``RTE_ETH_FOREACH_MATCHING_DEV``
> > +  and ``rte_dev_probe`` or ``rte_eal_hotplug_add``.
> > +  ``rte_eth_dev_detach`` can be replaced by
> > +  ``rte_dev_remove`` or ``rte_eal_hotplug_remove``.
> 
> What is the difference between ``rte_dev_remove`` or ``rte_eal_hotplug_remove``,
> which one is good for which usage, is there any documentation explaining this?

In doxygen, you can see that the parameters are differents, and new ones
are experimental.
That's why we'll keep old ones, at least for this release.





More information about the dev mailing list