[dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

Honnappa Nagarahalli Honnappa.Nagarahalli at arm.com
Tue Oct 23 17:52:48 CEST 2018


> > > > ---
> > >
> > > Does this need to be done via a completely new test case? Given the
> > > number of unit tests for the hash table structure, I'm wondering if
> > > we can consolidate things a bit. Any thoughts?
> > >
> > Are you concerned about new test case or new test case file?
> > From a new test case perspective, we are testing a new use case, hence we
> need it. May be few parts can be combined such as generating the keys.
> > From a new test case file perspective, combining this use case with
> existing files was making the code difficult to manage. Hence we decided to
> add a new file.
> >
> > There are more test cases because of multiple configuration options
> present in hash table.
> >
> Ok. That makes sense. Can you fix the couple of missing items for
> make/meson in this patch, then you can add my ack.
Yes, I will add that and send out v6, I will add your acked-by.

> 
> Acked-by: Bruce Richardson <bruce.richardson at intel.com>



More information about the dev mailing list