[dpdk-dev] [PATCH] common/dpaax: fix incorrect error case

Shreyansh Jain shreyansh.jain at nxp.com
Wed Oct 24 07:44:09 CEST 2018


In case the memory for nodes cannot be allocated, there is no need
to check for the length. Also, `node_count` is an unsigned value
and cannot be less than 0.

Coverity issue: 323521

Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table")
Cc: shreyansh.jain at nxp.com

Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
---
 drivers/common/dpaax/dpaax_iova_table.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c
index d54267bb7..19a4e8c58 100644
--- a/drivers/common/dpaax/dpaax_iova_table.c
+++ b/drivers/common/dpaax/dpaax_iova_table.c
@@ -172,7 +172,7 @@ dpaax_iova_table_populate(void)
 	}
 
 	nodes = read_memory_node(&node_count);
-	if (nodes == NULL || node_count <= 0) {
+	if (nodes == NULL) {
 		DPAAX_WARN("PA->VA translation not available;");
 		DPAAX_WARN("Expect performance impact.");
 		return -1;
-- 
2.17.1



More information about the dev mailing list