[dpdk-dev] [PATCH] vhost: initialize postcopy ufd properly

Maxime Coquelin maxime.coquelin at redhat.com
Wed Oct 24 12:20:41 CEST 2018



On 10/24/18 11:39 AM, Tiwei Bie wrote:
> Currently, postcopy_ufd is initialized to 0 implicitly, so fd 0
> could be closed unexpectedly by vhost_backend_cleanup(). Fix this
> issue by initializing postcopy_ufd to -1 explicitly.
> 
> Fixes: 9eefef3b5970 ("vhost: introduce postcopy advise message")
> 
> Signed-off-by: Tiwei Bie <tiwei.bie at intel.com>
> ---
>   lib/librte_vhost/vhost.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index 047ee535c..70ac6bc9c 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -344,6 +344,7 @@ vhost_new_device(void)
>   	dev->flags = VIRTIO_DEV_BUILTIN_VIRTIO_NET;
>   	dev->slave_req_fd = -1;
>   	dev->vdpa_dev_id = -1;
> +	dev->postcopy_ufd = -1;
>   	rte_spinlock_init(&dev->slave_req_lock);
>   
>   	return i;
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

Thanks!
Maxime


More information about the dev mailing list