[dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation

Akhil Goyal akhil.goyal at nxp.com
Wed Oct 24 15:09:41 CEST 2018


>>> @@ -153,10 +153,13 @@ test_rsa_sign_verify(void)
>>>                goto error_exit;
>>>        }
>>>        status = TEST_SUCCESS;
>>> -     int ret = 0;
>>> -     ret = rsa_verify(&rsaplaintext, result_op);
>>> -     if (ret)
>>> +     if (result_op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
>>> +             RTE_LOG(ERR, USER1,
>>> +                             "line %u FAILED: %s",
>>> +                             __LINE__, "Failed to process asym crypto op");
>>>                status = TEST_FAILED;
>>> +             goto error_exit;
>>> +     }
>>>
>>>    error_exit:
>>>
>> What about test_rsa_enc_dec? Do you need to remove verify from that as well?
> No. in case of enc_dec, PMD just return decrypted o/p so, app need to do cross-verify data.
> In case of RSA_VERIFY OP PMD internally does memcmp of plaintext to decrypted o/p and ensure
> Pass / fail. So, doing it again at app level is redundant.
Ok
> Thanks
> Shally



More information about the dev mailing list