[dpdk-dev] [dpdk-stable] [PATCH] ipc: fix undefined behavior in no-shconf mode

Thomas Monjalon thomas at monjalon.net
Wed Oct 24 16:47:21 CEST 2018


24/10/2018 12:20, Burakov, Anatoly:
> On 24-Oct-18 11:05 AM, Darek Stojaczyk wrote:
> > In no-shconf mode the rte_mp_request_sync() wasn't initializing
> > the `reply` parameter, which contained e.g. a number of sent
> > requests. Callers of rte_mp_request_sync() might check that
> > param afterwards and might read potentially unitialized memory.
> > 
> > The no-shconf check that makes us return early (with rc = 0) was
> > placed before the `reply` initialization. Fix this by making the
> > `reply` initialization occur first.
> > 
> > Fixes: 5848e3d2813c ("ipc: support --no-shconf mode")
> > Cc: anatoly.burakov at intel.com
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk at intel.com>
> > ---
> 
> Acked-by: Anatoly Burakov <anatoly.burakov at intel.com>

Applied, thanks




More information about the dev mailing list