[dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration
Thomas Monjalon
thomas at monjalon.net
Wed Oct 24 21:55:15 CEST 2018
24/10/2018 17:55, Iremonger, Bernard:
> Hi Thomas,
>
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> > +/* Pretty printing of ethdev events */
> > +static const char * const eth_event_desc[] = {
> > + [RTE_ETH_EVENT_UNKNOWN] = "unknown",
> > + [RTE_ETH_EVENT_INTR_LSC] = "LSC",
>
> How about replacing "LSC" with "interrupt link status change"
When it is printed, "event" is appended.
So I think "interrupt" is a bit too much.
OK for "link state change"?
> > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state",
> > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset",
> > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox",
> > + [RTE_ETH_EVENT_IPSEC] = "IPsec",
> > + [RTE_ETH_EVENT_MACSEC] = "MACsec",
> > + [RTE_ETH_EVENT_INTR_RMV] = "device removal",
>
> How about replacing "device removal" with "interrupt device removal"
For same reason, I think "device removal" is enough.
It will be printed as "device removal event".
More information about the dev
mailing list