[dpdk-dev] [PATCH v6 4/5] examples/kni: add log msgs to show and clear stats

Stephen Hemminger stephen at networkplumber.org
Wed Oct 24 22:46:02 CEST 2018


On Wed, 24 Oct 2018 17:27:18 -0300
Dan Gora <dg at adax.com> wrote:

> +	pid = getpid();
> +	RTE_LOG(INFO, APP, "========================\n");
> +	RTE_LOG(INFO, APP, "KNI Running\n");
> +	RTE_LOG(INFO, APP, "kill -SIGUSR1 %d\n", pid);
> +	RTE_LOG(INFO, APP, "    Show KNI Statistics.\n");
> +	RTE_LOG(INFO, APP, "kill -SIGUSR2 %d\n", pid);
> +	RTE_LOG(INFO, APP, "    Zero KNI Statistics.\n");
> +	RTE_LOG(INFO, APP, "========================\n");
> +	fflush(stdout);
> +

Thanks for updating the example to cover the new code.

This seems like an overly wordy message which should really be in the documentation
not a billboard in the code.

In my opinion, having verbose messages is unhelpful since it just clutters
the experience.


More information about the dev mailing list