[dpdk-dev] [PATCH v8 05/13] telemetry: add client feature and sockets

Thomas Monjalon thomas at monjalon.net
Thu Oct 25 22:49:33 CEST 2018


25/10/2018 22:44, Bruce Richardson:
> On Thu, Oct 25, 2018 at 10:41:53PM +0200, Thomas Monjalon wrote:
> > 25/10/2018 22:29, Thomas Monjalon:
> > > 24/10/2018 18:03, Kevin Laatz:
> > > > --- a/lib/librte_telemetry/meson.build
> > > > +++ b/lib/librte_telemetry/meson.build
> > > > @@ -5,3 +5,5 @@ sources = files('rte_telemetry.c')
> > > >  headers = files('rte_telemetry.h', 'rte_telemetry_internal.h')
> > > >  deps += ['metrics', 'ethdev']
> > > >  cflags += '-DALLOW_EXPERIMENTAL_API'
> > > > +jansson = cc.find_library('jansson', required: true)
> > > > +ext_deps += jansson
> > > 
> > > I just discovered an issue when trying to compile for arm64
> > > (with devtools/test-meson-builds.sh):
> > > 
> > > /usr/lib/gcc/aarch64-linux-gnu/8.2.0/../../../../aarch64-linux-gnu/bin/ld:
> > > 	cannot find -ljansson
> > > 
> > > I am worried because it is a real blocker.
> > 
> > The dependency must be optional.
> > Should we disable the library if jansson is not found?
> >
> Yes, it should be.
> 
> Needs:
> 
> 	jansson = cc.find_library('jansson', required: false)
> 	build = jansson.found()

And for the makefile?

It has been introduced (too early) in patch 3:
	LDLIBS += -ljansson
I think we must use pkg-config to check if jansson is found.





More information about the dev mailing list