[dpdk-dev] [PATCH] eal: fixup hotplugging an already present device

Stojaczyk, Dariusz dariusz.stojaczyk at intel.com
Fri Oct 26 10:18:40 CEST 2018


> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Thursday, October 25, 2018 1:49 PM
> To: Stojaczyk, Dariusz <dariusz.stojaczyk at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org
> Subject: Re: [PATCH] eal: fixup hotplugging an already present device
> 
> 25/10/2018 12:51, Darek Stojaczyk:
> > We were returning rc = -1 from a device probing function
> > whenever the provided device was already probed before.
> >
> > This basically broke hotplugging a device in secondary
> > process when the same device was already hotplugged in
> > the primary.
> >
> > To fix it, just return 0 instead of -1. I believe this is
> > the originally intented behavior.
> 
> The intent was to return the error seen during probing again.
> If there is no error, the PMD must return 0.
> It means I reject this patch so far.
> 

I see, let's abandon this one.
I submitted another patch for PCI that resolves the mentioned hotplug issue:
[PATCH] pci: propagate exact error codes in pci_probe_all_drivers()

D.


More information about the dev mailing list