[dpdk-dev] [PATCH 2/4] bnx2x: remove profanity

Burakov, Anatoly anatoly.burakov at intel.com
Fri Oct 26 16:56:24 CEST 2018


On 25-Jul-18 7:20 PM, Stephen Hemminger wrote:
> No need for profanity in comments.
> 
> Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
> ---
>   drivers/net/bnx2x/elink.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c
> index 34a29373af3b..08fe817720a1 100644
> --- a/drivers/net/bnx2x/elink.c
> +++ b/drivers/net/bnx2x/elink.c
> @@ -3993,11 +3993,11 @@ static elink_status_t elink_get_mod_abs_int_cfg(struct bnx2x_softc *sc,
>   			   PORT_HW_CFG_E3_MOD_ABS_MASK) >>
>   		    PORT_HW_CFG_E3_MOD_ABS_SHIFT;
>   
> -		/* Should not happen. This function called upon interrupt
> +		/*
> +		 * Should not happen. This function called upon interrupt
>   		 * triggered by GPIO ( since EPIO can only generate interrupts
>   		 * to MCP).
>   		 * So if this function was called and none of the GPIOs was set,
> -		 * it means the shit hit the fan.

...then what? :)

>   		 */
>   		if ((cfg_pin < PIN_CFG_GPIO0_P0) ||
>   		    (cfg_pin > PIN_CFG_GPIO3_P1)) {
> 


-- 
Thanks,
Anatoly


More information about the dev mailing list