[dpdk-dev] [PATCH v2] buildtools: fix build for some mktemp

Thomas Monjalon thomas at monjalon.net
Sat Oct 27 01:47:01 CEST 2018


27/10/2018 02:38, Ferruh Yigit:
> build error:
> == Build drivers/net/tap
> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c:
> Invalid argument
> .../buildtools/auto-config-h.sh: line 86: : No such file or directory
> .../drivers/net/tap/Makefile:55: recipe for target
>    'tap_autoconf.h.new' failed
> 
> Above error observed on Wind River Linux 8.0
> 
> `mktemp` command in that system has a restrictions to have X in
> the template at the end and at least six of them.
> 
> Complied to mktemp requirements and add -xc flag to compiler to say
> `temp` file is a C file
> 
> Fixes: ff37ca5d3773 ("devtools: use a common prefix for temporary files")
> 
> Reported-by: Shuai Zhu <shuaix.zhu at intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> ---
> v2:
> * keep using mktemp, add -xc to compiler
> ---
>  buildtools/auto-config-h.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/buildtools/auto-config-h.sh
> +++ b/buildtools/auto-config-h.sh
> -temp=$(mktemp -t dpdk.${0##*/}.XXX.c)
> +temp=$(mktemp -t dpdk.${0##*/}.c.XXXXXX)

It looks OK for this script.

Should we do the same kind of change for devtools/check-includes.sh?
and devtools/cocci.sh?





More information about the dev mailing list