[dpdk-dev] [PATCH v3 0/6] use IOVAs check based on DMA mask

Burakov, Anatoly anatoly.burakov at intel.com
Tue Oct 30 11:10:11 CET 2018


On 29-Oct-18 7:37 PM, Alejandro Lucero wrote:
> 
> 
> On Mon, Oct 29, 2018 at 6:54 PM Yongseok Koh <yskoh at mellanox.com 
> <mailto:yskoh at mellanox.com>> wrote:
> 
> 
>      > On Oct 29, 2018, at 7:18 AM, Thomas Monjalon <thomas at monjalon.net
>     <mailto:thomas at monjalon.net>> wrote:
>      >
>      > 29/10/2018 14:40, Alejandro Lucero:
>      >> On Mon, Oct 29, 2018 at 1:18 PM Yao, Lei A <lei.a.yao at intel.com
>     <mailto:lei.a.yao at intel.com>> wrote:
>      >>> *From:* Alejandro Lucero [mailto:alejandro.lucero at netronome.com
>     <mailto:alejandro.lucero at netronome.com>]
>      >>> On Mon, Oct 29, 2018 at 11:46 AM Thomas Monjalon
>     <thomas at monjalon.net <mailto:thomas at monjalon.net>>
>      >>> wrote:
>      >>>
>      >>> 29/10/2018 12:39, Alejandro Lucero:
>      >>>> I got a patch that solves a bug when calling rte_eal_dma_mask
>     using the
>      >>>> mask instead of the maskbits. However, this does not solves the
>      >>> deadlock.
>      >>>
>      >>> The deadlock is a bigger concern I think.
>      >>>
>      >>> I think once the call to rte_eal_check_dma_mask uses the
>     maskbits instead
>      >>> of the mask, calling rte_memseg_walk_thread_unsafe avoids the
>     deadlock.
>      >>>
>      >>> Yao, can you try with the attached patch?
>      >>>
>      >>> Hi, Lucero
>      >>>
>      >>> This patch can fix the issue at my side. Thanks a lot
>      >>> for you quick action.
>      >>
>      >> Great!
>      >>
>      >> I will send an official patch with the changes.
>      >
>      > Please, do not forget my other request to better comment functions.
> 
>     Alejandro,
> 
>     This patchset has been merged to stable/17.11 per your request for
>     the last release.
>     You must send a fix to stable/17.11 as well, if you think there's a
>     same issue there.
> 
> 
> The patchset for 17.11 was much more simpler. There have been a lot of 
> changes to the memory code since 17.11, and this problem should not be 
> present in stable 17.11.
> 
> Once I have said that, if there are any reports about a problem with 
> this patchset in 17.11, I will work on it as a priority.
> 
> Thanks.
> 

17.11 will definitely be immune to the deadlock issue since there are no 
memseg walks there :) It however may still have incorrect mask handling.

-- 
Thanks,
Anatoly


More information about the dev mailing list