[dpdk-dev] [PATCH v2 2/5] vhost: make message handling functions prepare the reply

Maxime Coquelin maxime.coquelin at redhat.com
Mon Sep 10 17:08:20 CEST 2018



On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote:
> As VhostUserMsg structure is resued to generate the reply, move the

s/resued/reused/

> relevant fields update into the respective message handling functions.
> 
> Signed-off-by: Nikolay Nikolaev <nicknickolaev at gmail.com>
> ---
>   lib/librte_vhost/vhost_user.c |   26 ++++++++++++++++----------
>   1 file changed, 16 insertions(+), 10 deletions(-)
> 

Agree this is cleaner:
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>

For the typo, don't resend the series just for this if this is the only
thing to fix. I suspect a rebase may be required anyway as it may
conflict with a patch from Ilya.

Thanks,
Maxime


More information about the dev mailing list