[dpdk-dev] [PATCH v2] ethdev: make default behavior CRC strip on Rx

[Hyong Youb Kim]

On Tue, Sep 04, 2018 at 11:12:56AM +0100, Ferruh Yigit wrote:
> Removed DEV_RX_OFFLOAD_CRC_STRIP offload flag.
> Without any specific Rx offload flag, default behavior by PMDs is to
> strip CRC.
> 
> PMDs that support keeping CRC should advertise DEV_RX_OFFLOAD_KEEP_CRC
> Rx offload capability.
> 
> Applications that require keeping CRC should check PMD capability first
> and if it is supported can enable this feature by setting
> DEV_RX_OFFLOAD_KEEP_CRC in Rx offload flag in rte_eth_dev_configure()
[...]
> diff --git a/drivers/net/enic/enic_res.c b/drivers/net/enic/enic_res.c
> index 8d493ffed..abe004b24 100644
> --- a/drivers/net/enic/enic_res.c
> +++ b/drivers/net/enic/enic_res.c
> @@ -195,7 +195,6 @@ int enic_get_vnic_config(struct enic *enic)
>  	enic->rx_offload_capa =
>  		DEV_RX_OFFLOAD_SCATTER |
>  		DEV_RX_OFFLOAD_JUMBO_FRAME |
> -		DEV_RX_OFFLOAD_CRC_STRIP |
>  		DEV_RX_OFFLOAD_VLAN_STRIP |
>  		DEV_RX_OFFLOAD_IPV4_CKSUM |
>  		DEV_RX_OFFLOAD_UDP_CKSUM |

For net/enic.

Acked-by: Hyong Youb Kim <hyonkim at cisco.com>