[dpdk-dev] [PATCH 14/15] net/vmxnet3: rename version map after library file name

[Yong Wang]

-----Original Message-----
From: Luca Boccassi <bluca at debian.org>
Date: Monday, September 10, 2018 at 1:05 PM
To: "dev at dpdk.org" <dev at dpdk.org>
Cc: "keith.wiles at intel.com" <keith.wiles at intel.com>, "roy.fan.zhang at intel.com" <roy.fan.zhang at intel.com>, "jingjing.wu at intel.com" <jingjing.wu at intel.com>, "wenzhuo.lu at intel.com" <wenzhuo.lu at intel.com>, "rasesh.mody at cavium.com" <rasesh.mody at cavium.com>, "harish.patil at cavium.com" <harish.patil at cavium.com>, "shahed.shaikh at cavium.com" <shahed.shaikh at cavium.com>, "amr.mokhtar at intel.com" <amr.mokhtar at intel.com>, "shijith.thotton at cavium.com" <shijith.thotton at cavium.com>, "ssrinivasan at cavium.com" <ssrinivasan at cavium.com>, "liang.j.ma at intel.com" <liang.j.ma at intel.com>, "peter.mccarthy at intel.com" <peter.mccarthy at intel.com>, "jerin.jacob at caviumnetworks.com" <jerin.jacob at caviumnetworks.com>, "maciej.czekaj at caviumnetworks.com" <maciej.czekaj at caviumnetworks.com>, "arybchenko at solarflare.com" <arybchenko at solarflare.com>, "antosh.shukla at caviumnetworks.com" <antosh.shukla at caviumnetworks.com>, "ashish.gupta at cavium.com" <ashish.gupta at cavium.com>, Yong Wang <yongwang at vmware.com>, "bruce.richardson at intel.com" <bruce.richardson at intel.com>, "thomas at monjalon.net" <thomas at monjalon.net>
Subject: [PATCH 14/15] net/vmxnet3: rename version map after library file name

    The library is called librte_pmd_vmxnet3_uio, so rename the map
    file and set the name in the meson file so that the built library names
    with meson and legacy makefiles are the same
    
    Signed-off-by: Luca Boccassi <bluca at debian.org>
    ---

Not directly related to this change but I have some question on the uio naming.  The original motivation is from the following commit:

commit 1daf0aae7fd6b3bc38952e9817a1653c1258be66
Author: Thomas Monjalon <thomas.monjalon at 6wind.com>
Date:   Fri Mar 21 13:52:17 2014 +0100

    vmxnet3: rename library
    
    In order to distinguish clearly this implementation from the extension
    vmxnet3-usermap, it is renamed to reflect its usage of uio framework.
    
    Signed-off-by: Thomas Monjalon <thomas.monjalon at 6wind.com>
    Acked-by: Thomas Graf <tgraf at redhat.com>

However, this version of vmxnet3 can also be bound to vfio-pci driver.  I think having the uio naming in that case will be misleading. 

     drivers/net/vmxnet3/Makefile                                    | 2 +-
     ..._pmd_vmxnet3_version.map => rte_pmd_vmxnet3_uio_version.map} | 0
     2 files changed, 1 insertion(+), 1 deletion(-)
     rename drivers/net/vmxnet3/{rte_pmd_vmxnet3_version.map => rte_pmd_vmxnet3_uio_version.map} (100%)
    
    diff --git a/drivers/net/vmxnet3/Makefile b/drivers/net/vmxnet3/Makefile
    index f1141da674..9848cd224f 100644
    --- a/drivers/net/vmxnet3/Makefile
    +++ b/drivers/net/vmxnet3/Makefile
    @@ -43,7 +43,7 @@ LDLIBS += -lrte_bus_pci
     
     VPATH += $(SRCDIR)/base
     
    -EXPORT_MAP := rte_pmd_vmxnet3_version.map
    +EXPORT_MAP := rte_pmd_vmxnet3_uio_version.map
     
     LIBABIVER := 1
     
    diff --git a/drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map b/drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
    similarity index 100%
    rename from drivers/net/vmxnet3/rte_pmd_vmxnet3_version.map
    rename to drivers/net/vmxnet3/rte_pmd_vmxnet3_uio_version.map
    -- 
    2.18.0