[dpdk-dev] [PATCH v2 01/33] config: add Cavium OcteonTX crypto PMD skeleton

Akhil Goyal akhil.goyal at nxp.com
Mon Sep 17 12:37:44 CEST 2018



>>>
>> I think it would be better to squash the makefile related changes in 
>> the 3/33 patch as the code
>>
>> is actually added in that and here the code is not getting compiled 
>> here.
> So the changes in the following files has to be moved to patch 3/33?
>   drivers/crypto/Makefile
>   drivers/crypto/meson.build
>   drivers/crypto/octeontx/Makefile
>   drivers/crypto/octeontx/meson.build
>   mk/rte.app.mk
>
> I think this patch will just have MAINTAINER edit (even that might be 
> required to be moved to 3/33?) & changes to config/common_base, after 
> that. Is that fine?
In my opinion, you do not need this patch as separate one. 
config/common_base can also be added in the 3/33.
>>
>> -Akhil
>>
>



More information about the dev mailing list