[dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine

[Joseph, Anoob]

Hi Thomas,

On 17-09-2018 17:16, Thomas Monjalon wrote:
> External Email
>
> 17/09/2018 12:45, Akhil Goyal:
>> On 9/4/2018 9:28 AM, Anoob Joseph wrote:
>>> +struct pending_queue {
>>> +   uint16_t enq_tail;
>>> +   uint16_t deq_head;
>>> +   uint16_t soft_qlen;
>>> +           /**< Software expected queue length */
>>> +   uint16_t p_doorbell;
>>> +   struct rid *rid_queue;
>>> +           /**< Array of pending requests */
>>> +   uint64_t pending_count;
>>> +           /**< Pending requests count */
>>> +};
>> better to add comment for each element of structure.
>> Also remove extra tab for comments(here and any other place if any.)
> I don't understand this trend in the community about doing comments
> _after_ the item _and_ not on the same line.
> The default style should be commenting _before_.
> And if you feel it is better to have the comment on the same line,
> then you can comment _after_, but on the same line.
Will fix it. Saw comments after the item being used frequently and 
thought that was the convention.

Thanks
Anoob