[dpdk-dev] [PATCH] test-meson-builds: add 32-bit compilation test

Thomas Monjalon thomas at monjalon.net
Mon Sep 17 15:38:58 CEST 2018


17/09/2018 14:54, Bruce Richardson:
> On Mon, Sep 17, 2018 at 02:03:50PM +0200, Thomas Monjalon wrote:
> > 29/08/2018 18:02, Bruce Richardson:
> > > Add in a cross-file to enable 32-bit compile tests as part
> > > of the test-meson-builds script.
> > > 
> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > > ---
> > > NOTE: For ease of use, it's recommended that meson 0.47 be used for
> > > this testing. With earlier versions, it may be necessary to ensure that
> > > the same development packages are installed for both 64-bit and 32-bit.
> > > ---
> > >  config/x86/i686_sse4_linuxapp_gcc | 18 ++++++++++++++++++
> > >  devtools/test-meson-builds.sh     |  4 ++++
> > >  2 files changed, 22 insertions(+)
> > 
> > I'm not sure about adding this test as mandatory, because 32-bit version
> > of libraries can be hard to get, especially libbsd and libnuma.
> > I hope this test will be run by all developers, so we should not discourage
> > them by adding too many requirements.
> > Opinion? Idea?
> 
> Libbsd is not required, but yes, libnuma is, so you do need a 32-bit
> libnuma (devel) installed to run this test. I would expect that to be
> available on most distros though. I'm open to suggestions as to how to make
> this optional, but I do think that sanity checking 32-bit is good practice
> to avoid errors, e.g. those wonderful printf format strings for uint64_t.*

I agree and I am testing i686 with the "make build system".
I define DPDK_DEP_NUMA=n which disables any NUMA option.
Can we have this kind of tweak with meson?

Or perhaps we can just have an option in the script to disable this test?




More information about the dev mailing list