[dpdk-dev] [PATCH v6] net/i40e: add interface to use latest vec path

[Li, Xiaoyun]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas at monjalon.net]
> Sent: Monday, September 17, 2018 22:37
> To: Yigit, Ferruh <ferruh.yigit at intel.com>
> Cc: Li, Xiaoyun <xiaoyun.li at intel.com>; Xing, Beilei <beilei.xing at intel.com>;
> Zhang, Qi Z <qi.z.zhang at intel.com>; dev at dpdk.org; Yang, Zhiyong
> <zhiyong.yang at intel.com>; Richardson, Bruce <bruce.richardson at intel.com>
> Subject: Re: [PATCH v6] net/i40e: add interface to use latest vec path
> 
> 17/09/2018 16:14, Ferruh Yigit:
> > On 9/17/2018 10:58 AM, Xiaoyun Li wrote:
> > > @@ -1078,6 +1078,9 @@ struct i40e_adapter {
> > >  	uint64_t pctypes_tbl[I40E_FLOW_TYPE_MAX]
> __rte_cache_min_aligned;
> > >  	uint64_t flow_types_mask;
> > >  	uint64_t pctypes_mask;
> > > +
> > > +	/* For devargs */
> > > +	bool use_latest_vec;
> >
> > For this one checkpatch is giving following warning:
> >
> > CHECK:BOOL_MEMBER: Avoid using bool structure members because of
> > possible alignment issues - see: https://lkml.org/lkml/2017/11/21/384
> >
> > The comment in the link seems valid. What do you think using a basic
> > storage type for the variable, like uint8_t?
> >
> >
> > And overall is there any objection to follow this new convention?
> 
> I agree with avoiding bool in structs.
> 
OK. Thanks!