[dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

Zhang, Qi Z qi.z.zhang at intel.com
Tue Sep 18 16:20:41 CEST 2018



> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ye Xiaolong
> Sent: Friday, September 14, 2018 4:42 PM
> To: Wang, Xiao W <xiao.w.wang at intel.com>
> Cc: Bie, Tiwei <tiwei.bie at intel.com>; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready
> 
> Looks good to me.
> 
> Reviewed-by: Ye Xiaolong <xiaolong.ye at intel.com>
> 
> Thanks,
> Xiaolong
> 
> On 09/14, Xiao Wang wrote:
> >If the device is not clearly reset by the previous driver and holds
> >some invalid ring addr, and the relay thread kicks it before HW is
> >properly re-configured, a bad DMA request may happen.
> >
> >Besides, the notify_addr which is used by the relay thread is set in
> >the vdpa_ifcvf_start function, if a kick relay happens before
> >vdpa_ifcvf_start finishes, a null addr is accessed.
> >
> >Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> >
> >Signed-off-by: Xiao Wang <xiao.w.wang at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


More information about the dev mailing list