[dpdk-dev] [PATCH v2 02/13] net/dpaa: fix jumbo buffer config

Hemant hemant.agrawal at nxp.com
Tue Sep 18 18:22:06 CEST 2018



On 9/18/2018 7:33 PM, Thomas Monjalon wrote:
> 18/09/2018 15:31, Hemant Agrawal:
>> Avoid return after the jumbo buffer config in dev config API
>>
>> Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal at nxp.com>
> Thanks for adding some comments in this series.
>
> About this fix, would it be easier to understand if explaining
> what is the bug first?
>
>
yes. I can be more specific here.
1. the dev->data->mtu was not getting updated earlier for the jumbo 
buffer config.
2. we don't expect to return error, if this config fails. A debug err 
log is ok.  DPAA1 - supports jumbo by default, enable/disable may give 
errors.


More information about the dev mailing list