[dpdk-dev] [PATCH 1/7] net/bnxt: get rid of ff pools array and use the vnic info array

[Ferruh Yigit]

On 9/1/2018 5:32 AM, Ajit Khaparde wrote:
> From: Somnath Kotur <somnath.kotur at broadcom.com>
> 
> There was no direct association between the rxq's vnic and the vnic_info[].
> Explicitly associate the two in bnxt_mq_rx_configure().
> 
> Fixes: f7c3d72afff7 ("net/bnxt: fix Rx ring count limitation")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Somnath Kotur <somnath.kotur at broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>

<...>

>  void bnxt_free_vnic_attributes(struct bnxt *bp)
>  {
>  	struct bnxt_vnic_info *vnic;
> +	unsigned int i;
>  
> -	STAILQ_FOREACH(vnic, &bp->free_vnic_list, next) {
> +	for (i = 0; i < bp->nr_vnics; i++) {
>  		if (vnic->rss_table) {

Here vnic accessed without initial value [1], I guess intention was:
 "vnic = &bp->vnic_info[i];" before access.

[1]
.../drivers/net/bnxt/bnxt_vnic.c:93:7: error: variable 'vnic' is uninitialized
when used here [-Werror,-Wuninitialized]
                if (vnic->rss_table) {
                    ^~~~