[dpdk-dev] [PATCH] eal: fix '--huge-unlink' option
Stojaczyk, Dariusz
dariusz.stojaczyk at intel.com
Fri Sep 21 10:31:09 CEST 2018
I'd like to point out that the comments inside eal_memory.c are outdated (e.g. the one from line #249). It makes it difficult to review this patch.
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Pawel Wodkowski
> Sent: Friday, September 21, 2018 1:57 PM
> To: dev at dpdk.org
> Cc: Wodkowski, PawelX <pawelx.wodkowski at intel.com>
> Subject: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option
>
> The final_va field is set during remap_segment() but this information is not
> propagated to temporal copy of huge page memory configuration so the
> unlink_hugepage_files() function wrongly assume that there is nothing to
> unlink. Fix this issue by checking orig_va instead of final_va.
>
> Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists")
> To: Anatoly Burakov <anatoly.burakov at intel.com>
>
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski at intel.com>
More information about the dev
mailing list