[dpdk-dev] [PATCH 2/5] net/bnx2x: update link/PHY management

[Mody, Rasesh]

>From: Ferruh Yigit <ferruh.yigit at intel.com>
>Sent: Friday, September 21, 2018 11:10 AM
>
>On 9/19/2018 10:59 PM, Mody, Rasesh wrote:
>> This patch has changes to update the link/PHY management (elink) code
>> to the latest.
>>
>> Signed-off-by: Rasesh Mody <rasesh.mody at cavium.com>
>> ---
>>  drivers/net/bnx2x/bnx2x.h     |    3 +
>>  drivers/net/bnx2x/ecore_hsi.h |   20 +-
>>  drivers/net/bnx2x/elink.c     | 7951 ++++++++++++++++++++++++++--------
>-------
>>  drivers/net/bnx2x/elink.h     |  234 +-
>>  4 files changed, 5231 insertions(+), 2977 deletions(-)
>
><...>
>
>>
>> -static uint8_t elink_xgxs_config_init(struct elink_phy *phy,
>> -                                   struct elink_params *params,
>> -                                   struct elink_vars *vars)
>> +static void elink_xgxs_config_init(struct elink_phy *phy,
>> +                                struct elink_params *params,
>> +                                struct elink_vars *vars)
>
>
>Getting many build error because of these kind of changes.
>
>.../drivers/net/bnx2x/elink.c:12555:17: error: cast between incompatible
>function types from ‘void (*)(struct elink_phy *, struct elink_params *, struct
>elink_vars *)’ to ‘uint8_t (*)(struct elink_phy *, struct elink_params *, struct
>elink_vars *)’ {aka ‘unsigned char (*)(struct elink_phy *,  struct elink_params
>*, struct elink_vars *)’} [-Werror=cast-function-type]
>
>
>
>  .config_init = (config_init_t)elink_xgxs_config_init,
>
>
>
>                 ^
>
>perhaps "struct elink_phy" also needs to be updated?
>
>Overall build fail log is long, I am not sharing here, I guess if you can able to
>reproduce one, you will be able to reproduce all.

We didn’t see build errors with an older gcc. We'll reproduce with latest gcc and address the build errors.