[dpdk-dev] [PATCH v3 3/4] app/test-eventdev: add Tx adapter support

Andrzej Ostruszka amo at semihalf.com
Mon Sep 24 10:30:30 CEST 2018


On 23.09.2018 13:35, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Thu, 20 Sep 2018 03:52:34 +0530
>> From: Pavan Nikhilesh <pbhagavatula at caviumnetworks.com>
[...]
>> -	struct rte_event_dev_info info;
>> -	struct test_pipeline *t = evt_test_priv(test);
>> -	uint8_t tx_evqueue_id = 0;
>> +	uint8_t tx_evqueue_id[RTE_MAX_ETHPORTS] = {0};
> 
> Some old compiler throws error with this scheme. Please change to memset.

Really?  Could you give an example?

That is perfectly legal C (since "forever"?) and I find it more readable
than memset.  Don't treat it as a request to keep the original version -
if I were Pavan I would object this particular request since I prefer
direct initialization, however here I'm more interested in learning more
about your statement about compilers not supporting zero initialization
of array members after the last initializer.  And maybe also about to
what extent we should be supporting old/non compliant compilers (the doc
suggest to use gcc 4.9+).

Best regards
Andrzej


More information about the dev mailing list