[dpdk-dev] [PATCH v2 08/12] net/bnxt: use correct macro to register VF async event completion ring

Ferruh Yigit ferruh.yigit at intel.com
Tue Sep 25 13:30:13 CEST 2018


On 9/22/2018 5:55 AM, Ajit Khaparde wrote:
> From: yongping <yongping at broadcom.com>
> 
> While registering vf's event completion ring to FW, use the wrong
> macro, FW doesn't set up the event completion ring successfully,
> VF can't receive any async event.

Isn't this a fix that you would want to backport?

If so can you please update the commit log according, and perhaps it can be
better to move this patch before HWRM update patch, to help stable tree maintainers.

> 
> Signed-off-by: yongping <yongping at broadcom.com>

Can you please use "Name Surname <mail_address_all_lowercase>" syntax?

> Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 62da254b9..51fe3a4c2 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp)
>  	HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB);
>  
>  	req.enables = rte_cpu_to_le_32(
> -			HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
> +			HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR);
>  	req.async_event_cr = rte_cpu_to_le_16(
>  			bp->def_cp_ring->cp_ring_struct->fw_ring_id);
>  	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
> 



More information about the dev mailing list