[dpdk-dev] [PATCH] net/netvsc: check return from kvargs_process

Stephen Hemminger stephen at networkplumber.org
Wed Sep 26 11:31:12 CEST 2018


Should check return value from processing latency value.

Coverity issue: 322104
Signed-off-by: Stephen Hemminger <sthemmin at microsoft.com>
---
Patch against dpdk-next-net

 drivers/net/netvsc/hn_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index b67cce1ba8f5..8845fc0e6176 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -167,6 +167,7 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
 		NULL
 	};
 	struct rte_kvargs *kvlist;
+	int ret;
 
 	if (!devargs)
 		return 0;
@@ -180,9 +181,12 @@ static int hn_parse_args(const struct rte_eth_dev *dev)
 		return -EINVAL;
 	}
 
-	rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	ret = rte_kvargs_process(kvlist, "latency", hn_set_latency, hv);
+	if (ret)
+		PMD_DRV_LOG(ERR, "Unable to process latency arg\n");
+
 	rte_kvargs_free(kvlist);
-	return 0;
+	return ret;
 }
 
 /* Update link status.
-- 
2.17.1



More information about the dev mailing list