[dpdk-dev] [PATCH v2] vhost: fix corner case for enqueue operation

Maxime Coquelin maxime.coquelin at redhat.com
Thu Sep 27 14:37:58 CEST 2018



On 09/27/2018 02:24 PM, Maxime Coquelin wrote:
> 
> 
> On 09/17/2018 05:54 AM, Jiayu Hu wrote:
>> When perform enqueue operations on the split and packed ring,
> s/perform/performing/
> s/ring/rings/
>> if the reserved buffer length from the descriptor table execeeds
>> 65535, the returned length by fill_vec_buf_split/_packed() is
>> overflowed. This patch is to avoid this corner case.
> s/overflowed/overflows/
>>
>> Fixes: f689586b ("vhost: shadow used ring update")
>> Fixes: fd68b473 ("vhost: use buffer vectors in dequeue path")
>> Fixes: 2f3225a7 ("vhost: add vector filling support for packed ring")
>> Fixes: 37f5e79a ("vhost: add shadow used ring support for packed rings")
>> Fixes: a922401f ("vhost: add Rx support for packed ring")
>> Fixes: ae999ce4 ("vhost: add Tx support for packed ring")
>>
>> Signed-off-by: Jiayu Hu <jiayu.hu at intel.com>
>> ---
>>   lib/librte_vhost/virtio_net.c | 20 +++++++++++---------
>>   1 file changed, 11 insertions(+), 9 deletions(-)
>>
> 
> Other than that, the patch looks good to me. Thanks for fixing it.
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> 
> Maxime

Applied to dpdk-next-virtio/master with commit message fix.

Thanks,
Maxime


More information about the dev mailing list