[dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping

Thomas Monjalon thomas at monjalon.net
Tue Apr 2 02:34:15 CEST 2019


01/04/2019 19:17, Laatz, Kevin:
> On 28/03/2019 15:30, Bruce Richardson wrote:
> > If we have two NIC ports which have a different set of NIC stats we can
> > end up having two different stats registered with xstats with the same
> > name. [Since the stats are updated in bulk as a contiguous set, the
> > second driver re-using the registration of the first is not possible.]
> >
> > This causes issues with the invalid stat for one driver being found due to
> > a lookup by name which is unnecessary. Instead of getting stat names
> > involved do the lookup by ID instead.
> >
> > CC: stable at dpdk.org
> > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
> > ---
> 
> Looks good to me! Thanks.
> 
> Acked-by: Kevin Laatz <kevin.laatz at intel.com>

Applied, thanks




More information about the dev mailing list