[dpdk-dev] [dpdk-stable] [PATCH v2] eal: initialize alarms early

Thomas Monjalon thomas at monjalon.net
Tue Apr 2 15:01:14 CEST 2019


01/04/2019 16:18, Darek Stojaczyk:
> On linux, we currently initialize rte_alarms after
> starting to listen for IPC hotplug requests, which gives
> us a data race window. Upon receiving such hotplug
> request we always try to set an alarm and this obviously
> doesn't work if the alarms weren't initialized yet.
> 
> To fix it, we initialize alarms before starting to
> listen for IPC hotplug messages. Specifically, we move
> rte_eal_alarm_init() right after rte_eal_intr_init() as
> it makes some sense to keep those two close to each other.
> 
> We update the bsd code as well to keep the initialization
> order the same in both eal implementations.
> 
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: Qi Zhang <qi.z.zhang at intel.com>
> Cc: Anatoly Burakov <anatoly.burakov at intel.com>
> Cc: stable at dpdk.org
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk at intel.com>
> ---
> v2:
>  - updated the bsd code as well (Thomas)

Applied, thanks





More information about the dev mailing list