[dpdk-dev] [PATCH v2 3/3] rxtx_callbacks: Add support for HW timestamp

Tom Barbette barbette at kth.se
Tue Apr 2 21:39:16 CEST 2019


Le 02/04/2019 à 20:22, Ferruh Yigit a écrit :
> Same comment as ethdev one, above code assume if driver announces
> 'DEV_RX_OFFLOAD_TIMESTAMP' capability, it have to implement 'read_clock'
> dev_ops, should it be the case?
> 
> Write now only mlx implements it so this is not a problem at all, but I don't
> know if all PMDs supports timestamping packets must implement 'read_clock'.

I changed the init code to fail if rte_eth_read_clock did not work 
during the initialization of the base clock.

Other comments are applied.

Thanks!

Tom


More information about the dev mailing list