[dpdk-dev] [PATCH v5 2/2] app/pdump: enhance to support multi-core capture

[Varghese, Vipin]

Hi Reshma,

snipped
> > +
> > +	printf(" core (%u); port %u device (%s) queue %u\n",
> > +			rte_lcore_id(), pt->port, pt->device_id, pt->queue);
> 
> Log message can be improved to be "  packet_dump for port <num> running on
> core <id>"
Thanks for the suggestion, but I am comfortable with this message.

> 
> > +	fflush(stdout);
> 
> Why is fflush used here and  in below other places?
To ensure the stdout content is flushed out. We had used similar approach to ' examples/l2fwd/main.c'

> 
> >
> > +The ``--multi`` command line option is optional argument. If passed,
> > +capture will be running on unqiue cores for all ``--pdump`` options.
> > +If
> 
> Typo unique
> 
> Thanks,
> Reshma