[dpdk-dev] [PATCH 3/5] devtools/cocci: create safer version of strlcpy script

Bruce Richardson bruce.richardson at intel.com
Wed Apr 3 16:45:03 CEST 2019


The existing cocci script for coccinelle replaces all matching instances
of snprintf() with strlcpy() without regards to header inclusion. To allow
changes without build errors, we create a safer version of this script
that only makes changes when the rte_string_fns.h header is already
included.

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
 devtools/cocci/strlcpy-with-header.cocci | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 devtools/cocci/strlcpy-with-header.cocci

diff --git a/devtools/cocci/strlcpy-with-header.cocci b/devtools/cocci/strlcpy-with-header.cocci
new file mode 100644
index 000000000..046cdbdad
--- /dev/null
+++ b/devtools/cocci/strlcpy-with-header.cocci
@@ -0,0 +1,12 @@
+ at include@
+@@
+
+#include <rte_string_fns.h>
+
+ at use_strlcpy depends on include@
+expression src, dst, size;
+@@
+(
+- snprintf(dst, size, "%s", src)
++ strlcpy(dst, src, size)
+)
-- 
2.20.1



More information about the dev mailing list