[dpdk-dev] [PATCH 2/3] net/virtio: fix null pointer checking

Mohammad Abdul Awal mohammad.abdul.awal at intel.com
Wed Apr 3 18:08:11 CEST 2019


Null value of device name should return error without further processing.

Fixes: 1c8489da56 ("net/virtio-user: fix multi-process support")

Signed-off-by: Mohammad Abdul Awal <mohammad.abdul.awal at intel.com>
---
 drivers/net/virtio/virtio_user_ethdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c
index 129c2b9ef..cefc6da66 100644
--- a/drivers/net/virtio/virtio_user_ethdev.c
+++ b/drivers/net/virtio/virtio_user_ethdev.c
@@ -516,6 +516,10 @@ virtio_user_pmd_probe(struct rte_vdev_device *dev)
 
 	if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
 		const char *name = rte_vdev_device_name(dev);
+		if (name == NULL) {
+			RTE_LOG(ERR, PMD, "Device name is NULL\n");
+			return -1;
+		}
 		eth_dev = rte_eth_dev_attach_secondary(name);
 		if (!eth_dev) {
 			RTE_LOG(ERR, PMD, "Failed to probe %s\n", name);
-- 
2.17.1



More information about the dev mailing list