[dpdk-dev] [PATCH v2 1/3] bus/fslmc: cleanup unused firmware code
Shreyansh Jain
shreyansh.jain at nxp.com
Fri Apr 5 13:19:51 CEST 2019
On 05/04/19 3:13 AM, Thomas Monjalon wrote:
> 04/04/2019 23:29, Ferruh Yigit:
>> On 4/4/2019 8:23 AM, Shreyansh Jain wrote:
>>> Removes some unused firmware code which was added in last bump
>>> of the firmware version. No current features uses these APIs.
>>>
>>> Signed-off-by: Shreyansh Jain <shreyansh.jain at nxp.com>
>>
>> <...>
>>
>>> diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h
>>> index 9af9097e5..cf3d15267 100644
>>> --- a/drivers/bus/fslmc/mc/fsl_dpci.h
>>> +++ b/drivers/bus/fslmc/mc/fsl_dpci.h
>>> @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io,
>>> uint16_t token,
>>> struct dpci_attr *attr);
>>>
>>> -/**
>>> - * struct dpci_peer_attr - Structure representing the peer DPCI attributes
>>> - * @peer_id: DPCI peer id; if no peer is connected returns (-1)
>>> - * @num_of_priorities: The pper's number of receive priorities; determines the
>>> - * number of transmit priorities for the local DPCI object
>>> - */
>>> -struct dpci_peer_attr {
>>> - int peer_id;
>>> - uint8_t num_of_priorities;
>>> -};
>>> -
>>> -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io,
>>> - uint32_t cmd_flags,
>>> - uint16_t token,
>>> - struct dpci_peer_attr *attr);
>>> -
>>> -int dpci_get_link_state(struct fsl_mc_io *mc_io,
>>> - uint32_t cmd_flags,
>>> - uint16_t token,
>>> - int *up);
>>
>> These needs to be removed from .map file too.
Wow! indeed a great catch.
And, yup, my bad. Sorry! I wish I had your eye-for-detail.
>
> Removed from master.
> Thanks for the catch.
>
>
More information about the dev
mailing list