[dpdk-dev] [PATCH v2 1/3] ethdev: add actions to modify TCP header fields
Andrew Rybchenko
arybchenko at solarflare.com
Mon Apr 8 15:53:54 CEST 2019
On 4/8/19 4:36 PM, Dekel Peled wrote:
> Regarding Andrew's suggestion: "Shouldn't these action be RTE_FLOW_ACTION_TYPE_MOD_TCP_{ACK,SEQ} with singed 32-bit integer parameter (negative to decrement, positive to increment)?"
> I will leave the actions as is, the action names indicate the operation they perform.
I think it is an overkill to have two actions for the purpose: DEC
(value) == INC ((uint32_t)-value)
If it is really important to have DEC and INC, please, make it clear
from actions documentation why.
Thanks,
Andrew.
More information about the dev
mailing list